Skip to content

Fixes #9347 #9706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Fixes #9347 #9706

wants to merge 5 commits into from

Conversation

Sharnabh
Copy link

@Sharnabh Sharnabh commented Oct 4, 2023 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 4, 2023
@cclauss
Copy link
Member

cclauss commented Oct 4, 2023 •
edited
Loading

Please change the title of this pull request so it describes what the PR does.

@ChrisO345
Copy link
Collaborator

#9347

ChrisO345
ChrisO345 reviewed Oct 4, 2023
View reviewed changes
bit_manipulation/add_largest_power_of_2_less_than_or_equal_to_a_given_number.py
"""


def add_largest(num: int) -> int:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename the file to be less wordy.
This function doesn't accomplish what the issue is referencing.

@Sharnabh @ChrisO345
Update bit_manipulation/add_largest_power_of_2_less_than_or_equal_to_…
93d4444 
…a_given_number.py

Co-authored-by: Chris O <46587501+ChrisO345@users.noreply.github.com>
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 5, 2023
@Sharnabh
Fixes #9347
50ff9c0 
Fixes #9347
The Function adds largest power of 2 less than or equal to a given number.
@Sharnabh
Merge branch 'Fixes_#9374' of https://github.com/Sharnabh/Python into…
1c9d4bc 
… Fixes_#9374
@Sharnabh Sharnabh changed the title Fixes #9374 Fixes #9347 Oct 5, 2023
@cclauss
Copy link
Member

cclauss commented Oct 5, 2023

#9706 (comment)

#9706 (comment)

@Sharnabh Sharnabh closed this by deleting the head repository Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisO345 ChrisO345 ChrisO345 left review comments

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sharnabh @cclauss @ChrisO345